From 5de3d6bc92a3dce752dad2ce2acc17071383b6fa Mon Sep 17 00:00:00 2001 From: eug-vs Date: Sat, 21 Mar 2020 17:51:01 +0300 Subject: fix: bind link to developer name --- src/components/GithubAvatar/GithubAvatar.tsx | 10 +++++++--- src/pages/Contribute/Contribute.tsx | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/components/GithubAvatar/GithubAvatar.tsx b/src/components/GithubAvatar/GithubAvatar.tsx index 6aab28e..5daaac1 100644 --- a/src/components/GithubAvatar/GithubAvatar.tsx +++ b/src/components/GithubAvatar/GithubAvatar.tsx @@ -9,11 +9,14 @@ interface PropTypes { username: string; } +const githubUrl = 'https://github.com/'; +const getUserGithubUrl = (username: string) => githubUrl + username; + const GithubAvatar: React.FC = ({ username }) => { if (username === 'anonymous') return ; - const githubUrl = `https://github.com/${username}`; - const avatarUrl = githubUrl + '.png'; + const userGithubUrl = getUserGithubUrl(username); + const avatarUrl = userGithubUrl + '.png'; const usernameTokens = username.split(/[ ,.\-_#@;]/g); const altText = ( (usernameTokens.length > 1)? @@ -23,7 +26,7 @@ const GithubAvatar: React.FC = ({ username }) => { ).toUpperCase() return ( - + {altText} @@ -31,5 +34,6 @@ const GithubAvatar: React.FC = ({ username }) => { ) }; +export { getUserGithubUrl }; export default GithubAvatar; diff --git a/src/pages/Contribute/Contribute.tsx b/src/pages/Contribute/Contribute.tsx index 77228a1..67f2b8a 100644 --- a/src/pages/Contribute/Contribute.tsx +++ b/src/pages/Contribute/Contribute.tsx @@ -15,7 +15,7 @@ import BugReportIcon from '@material-ui/icons/BugReport'; import NewReleasesIcon from '@material-ui/icons/NewReleases'; import { Window, ContentSection } from 'react-benzin'; -import GithubAvatar from '../../components/GithubAvatar/GithubAvatar'; +import GithubAvatar, { getUserGithubUrl } from '../../components/GithubAvatar/GithubAvatar'; import developers from '../../developers.json'; @@ -116,7 +116,7 @@ const Contribute: React.FC = () => {
- {developer.username} + {developer.username} {developer.role} -- cgit v1.2.3