From 87f4cefcf7cd72357b4f47d409942e27c5e2f689 Mon Sep 17 00:00:00 2001
From: eug-vs <eugene@eug-vs.xyz>
Date: Wed, 18 Dec 2024 03:15:33 +0100
Subject: feat!: correctly compute jacobian derivative

 - Make C/J pure functions of a constraint
 - Approximate J' using finite differences (dC'/dq)
 - fn enforce_constraints() no longer depends on dt
 - Use stable-but-slow finite differences method for J by default
 - Provide analytically derived Jacobian implementations for existing
   constraints
---
 physics/src/constraint/beam.rs | 37 ++++++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 9 deletions(-)

(limited to 'physics/src/constraint/beam.rs')

diff --git a/physics/src/constraint/beam.rs b/physics/src/constraint/beam.rs
index b353e13..f6907c0 100644
--- a/physics/src/constraint/beam.rs
+++ b/physics/src/constraint/beam.rs
@@ -14,8 +14,6 @@ enum BeamPoint {
 pub struct BeamConstraint {
     points: [BeamPoint; 2],
     pub length: Scalar,
-
-    jacobian: RowDVector<Scalar>,
 }
 
 impl ParticleSystem {
@@ -29,7 +27,6 @@ impl ParticleSystem {
                 BeamPoint::FromParticle(particle_ids[1]),
             ],
             length: (a.position - b.position).norm(),
-            jacobian: RowDVector::zeros(self.particles.len() * N),
         }));
     }
 
@@ -42,7 +39,6 @@ impl ParticleSystem {
                 BeamPoint::Static(point),
             ],
             length: (position - point).norm(),
-            jacobian: RowDVector::zeros(self.particles.len() * N),
         }));
     }
 }
@@ -66,11 +62,34 @@ impl Constraint for BeamConstraint {
         (a - b).norm() - self.length
     }
 
-    fn set_jacobian(&mut self, jacobian: RowDVector<Scalar>) {
-        self.jacobian = jacobian
-    }
+    fn jacobian(&self, q: &DVector<Scalar>) -> RowDVector<Scalar> {
+        let [a, b] = self.points.map(|p| {
+            match p {
+                BeamPoint::Static(p) => p.coords,
+                BeamPoint::FromParticle(id) => q.fixed_rows::<N>(id * N).into(),
+            }
+        });
+        let mut result = RowDVector::zeros(q.len());
+        match (a - b).try_normalize(0.0) {
+            Some(normal) => {
+                for i in 0..N {
+                    match self.points[0] {
+                        BeamPoint::FromParticle(id) => {
+                            result[id * N + i] = normal[i];
+                        }
+                        _ => {}
+                    }
+                    match self.points[1] {
+                        BeamPoint::FromParticle(id) => {
+                            result[id * N + i] = -normal[i];
+                        }
+                        _ => {}
+                    }
+                }
+            }
+            None => ()
+        };
 
-    fn jacobian_prev(&self) -> RowDVector<Scalar> {
-        self.jacobian.clone()
+        result
     }
 }
-- 
cgit v1.2.3