diff options
Diffstat (limited to 'src/components')
-rw-r--r-- | src/components/Header/Header.tsx | 2 | ||||
-rw-r--r-- | src/components/PollCard/PollCard.tsx | 9 | ||||
-rw-r--r-- | src/components/UploadImage/UploadImage.tsx | 24 |
3 files changed, 18 insertions, 17 deletions
diff --git a/src/components/Header/Header.tsx b/src/components/Header/Header.tsx index 363e300..d0d9081 100644 --- a/src/components/Header/Header.tsx +++ b/src/components/Header/Header.tsx @@ -62,7 +62,7 @@ const Header: React.FC<PropTypes> = ({ navigate, userImage }) => { </IconButton> <IconButton onClick={handleProfile}> { - userImage?.match(/\.(jpeg|jpg|gif|png)$/) !== null + userImage?.match(/\.(jpeg|jpg|gif|png)$/) ? <Avatar className={classes.avatar} src={userImage} /> : <AccountCircle /> } diff --git a/src/components/PollCard/PollCard.tsx b/src/components/PollCard/PollCard.tsx index f222a63..f82ea44 100644 --- a/src/components/PollCard/PollCard.tsx +++ b/src/components/PollCard/PollCard.tsx @@ -72,10 +72,13 @@ const PollCard: React.FC<PropTypes> = ({ initialPoll, navigate }) => { const handleLeft = () => vote('left'); const handleRight = () => vote('right'); - let leftPercentage = Math.round(100 * (left.votes / (left.votes + right.votes))); - let rightPercentage = 100 - leftPercentage; + let leftPercentage; + let rightPercentage; - if(Number.isNaN(leftPercentage) && Number.isNaN(rightPercentage)){ + if (left.votes || right.votes) { + leftPercentage = Math.round(100 * (left.votes / (left.votes + right.votes))); + rightPercentage = 100 - leftPercentage; + } else { leftPercentage = 0; rightPercentage = 0; } diff --git a/src/components/UploadImage/UploadImage.tsx b/src/components/UploadImage/UploadImage.tsx index 464a9cf..3a58e29 100644 --- a/src/components/UploadImage/UploadImage.tsx +++ b/src/components/UploadImage/UploadImage.tsx @@ -1,4 +1,4 @@ -import React, { useRef, useState } from 'react'; +import React, { useState } from 'react'; import Button from '@material-ui/core/Button'; import TextField from '@material-ui/core/TextField'; import Dialog from '@material-ui/core/Dialog'; @@ -8,24 +8,23 @@ import DialogContentText from '@material-ui/core/DialogContentText'; import DialogTitle from '@material-ui/core/DialogTitle'; interface PropTypes { - displayD: boolean; - setDisplayD: (d: boolean) => void; - callback: (a: string) => void; + display: boolean; + isOpen: (display: boolean) => void; + callback: (url: string) => void; } const UploadImage: React.FC<PropTypes> = ({ - displayD, setDisplayD, callback + display, isOpen, callback }) => { - const urlRef = useRef<HTMLInputElement | null>(null); const [url, setUrl] = useState(''); const handleClose = () => { - setDisplayD(false); + isOpen(false); }; - const update = () => { - callback(urlRef.current?.value || ''); - setDisplayD(false); + const handleSubmit = () => { + callback(url || ''); + isOpen(false); }; const handleChange = (event:React.ChangeEvent<HTMLInputElement>) => { @@ -34,7 +33,7 @@ const UploadImage: React.FC<PropTypes> = ({ return ( <div> - <Dialog open={displayD} onClose={handleClose}> + <Dialog open={display} onClose={handleClose}> <DialogTitle id="form-dialog-title">Upload an Image</DialogTitle> <DialogContent> <DialogContentText> @@ -48,7 +47,6 @@ const UploadImage: React.FC<PropTypes> = ({ type="text" fullWidth autoComplete="off" - inputRef={urlRef} onChange={handleChange} /> </DialogContent> @@ -56,7 +54,7 @@ const UploadImage: React.FC<PropTypes> = ({ <Button onClick={handleClose} color="primary"> Cancel </Button> - <Button onClick={update} color="primary" disabled={!url.length}> + <Button onClick={handleSubmit} color="primary" disabled={!url.length}> Submit </Button> </DialogActions> |